Skip to content

[server] Implement grpc/connect getTeam RPC #17068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 30, 2023
Merged

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Mar 28, 2023

Description

Adds implementation of GetTeam to server's gRPC/Connect API.

Adds tests where we start the server, construct a client and hit the API as if a real client would giving us a cheap integration test.

Related Issue(s)

How to test

  • Unit tests

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold for dependency

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-mp-server-team-service-get.7 because the annotations in the pull request description changed
(with .werft/ from main)

@easyCZ easyCZ force-pushed the mp/server-team-service branch from 8b9fee9 to 106d19a Compare March 29, 2023 08:23
@easyCZ easyCZ force-pushed the mp/server-team-service-get branch from 5e513f9 to bb54a2e Compare March 29, 2023 08:26
@roboquat roboquat added size/L and removed size/XXL labels Mar 29, 2023
Base automatically changed from mp/server-team-service to main March 29, 2023 12:58
@roboquat roboquat added size/XL and removed size/L labels Mar 29, 2023
@easyCZ easyCZ force-pushed the mp/server-team-service-get branch from d59bbf7 to a498f05 Compare March 29, 2023 13:14
@roboquat roboquat added size/L and removed size/XL labels Mar 29, 2023
@roboquat roboquat added size/XL and removed size/L labels Mar 29, 2023
@roboquat roboquat added size/L and removed size/XL labels Mar 29, 2023
@roboquat roboquat added size/XL and removed size/L labels Mar 29, 2023
@easyCZ easyCZ marked this pull request as ready for review March 29, 2023 19:48
@easyCZ easyCZ requested a review from a team March 29, 2023 19:48
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 29, 2023
Copy link
Contributor

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! So cool to see progress on this ❤️

@easyCZ
Copy link
Member Author

easyCZ commented Mar 30, 2023

/unhold

@roboquat roboquat merged commit 9fef280 into main Mar 30, 2023
@roboquat roboquat deleted the mp/server-team-service-get branch March 30, 2023 09:08
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XL team: webapp Issue belongs to the WebApp team
Projects
Status: In Validation
Development

Successfully merging this pull request may close these issues.

3 participants