Skip to content

Adjust mocha .only check #17071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Adjust mocha .only check #17071

merged 1 commit into from
Mar 29, 2023

Conversation

selfcontained
Copy link
Contributor

Description

Had some false positives with the existing .only check (would fail for any changes that included the word only. I've adjust the regex to match a bit more precisely.

Related Issue(s)

Fixes #

How to test

If the build passes then it should be a decent test, as the line change in this PR includes the words only, which would have failed it previously.

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@roboquat roboquat merged commit 70c4c49 into main Mar 29, 2023
@roboquat roboquat deleted the bmh/mocha-only-grep-fix branch March 29, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Validation
Development

Successfully merging this pull request may close these issues.

3 participants