Skip to content

Improve node-labeler #17087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2023
Merged

Improve node-labeler #17087

merged 1 commit into from
Mar 30, 2023

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Mar 29, 2023 •
edited
Loading

Description

Configuring timeouts in the HTTP transport does not respect the configured timeouts.
Using http.NewRequestWithContext solves the issue.

Release Notes

NONE

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@aledbf
Improve node-labeler logs
5257f78 
Signed-off-by: Manuel de Brito Fontes <[email protected]>
@aledbf aledbf force-pushed the aledbf/labeler-logs branch from 0f9475c to 5257f78 Compare March 29, 2023 23:11
@aledbf aledbf marked this pull request as ready for review March 29, 2023 23:51
@aledbf aledbf requested a review from a team March 29, 2023 23:51
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Mar 29, 2023
@aledbf aledbf changed the title Improve node-labeler logs Improve node-labele Mar 29, 2023
@aledbf aledbf changed the title Improve node-labele Improve node-labeler Mar 29, 2023
kylos101
kylos101 approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@roboquat roboquat merged commit 1a3c4b0 into main Mar 30, 2023
@roboquat roboquat deleted the aledbf/labeler-logs branch March 30, 2023 00:03
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylos101 kylos101 kylos101 approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
No open projects
🌌 Workspace Team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aledbf @kylos101 @roboquat