Skip to content

[ws-manager-mk2] Extract headless task failure (WKS-18) #17091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

WVerlaek
Copy link
Member

@WVerlaek WVerlaek commented Mar 30, 2023

Description

  • If a headless task container exits with a non-empty Message, consider it a failure (as we do with mk1).
  • Always log workspace status in reconciliations. We can disable at a later point, but without it it becomes almost impossible to debug workspace/pod state changes.
    • In addition, also log the pod status

Related Issue(s)

How to test

In a preview env, create an image build, restart ws-daemon during the build (which currently causes the build to fail), and observe the workspace exits with a Failed condition and doesn't transition through Initializing after Running.

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@WVerlaek WVerlaek requested a review from a team March 30, 2023 09:58
@WVerlaek WVerlaek self-assigned this Mar 30, 2023
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Mar 30, 2023
@roboquat roboquat merged commit f237376 into main Apr 3, 2023
@roboquat roboquat deleted the wv/mk2-prebuild-initializing branch April 3, 2023 08:25
@Gaynelpaul1
Copy link

L

@Gaynelpaul1
Copy link

Good

@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants