[server/db] resume periodic deleter on quorum re-election #17092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexTugarev
commented
Mar 30, 2023
| } else { | ||
| log.info("[PeriodicDbDeleter] Current instance is not the leader, periodic deleter will not run."); | ||
| } | ||
| this.periodicDbDeleter.start(async () => { |
There was a problem hiding this comment.
periodic deleter lives in gitpod-db, therefore I opted for the callback as signal of enablement.
There was a problem hiding this comment.
Nice, the main difference is we always start, but then do not run if we're not the leader.
easyCZ
approved these changes
Mar 30, 2023
roboquat
added
deployed: webapp
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quorum leader is re-elected whenever the leader got unresponsive, but the periodic deleter is only considering this once on server init. This can lead to a state where no deleter is active.
How to test
Release Notes
Documentation
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh