Skip to content

[test] Fix loop closures #17109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2023
Merged

[test] Fix loop closures #17109

merged 1 commit into from
Mar 31, 2023

Conversation

WVerlaek
Copy link
Member

Description

Fix loop closures, some parallel tests were accessing the loop variable which would most likely have changed value at the time it gets accessed

Related Issue(s)

Potentially might fix some flakiness with the tests?

How to test

This should no longer pick up any loopclosure lint errors:

cd test
golangci-lint run | grep closure

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@WVerlaek WVerlaek requested a review from a team March 31, 2023 09:22
@WVerlaek WVerlaek self-assigned this Mar 31, 2023
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Mar 31, 2023
@roboquat roboquat merged commit 768e949 into main Mar 31, 2023
@roboquat roboquat deleted the wv/test-fix-loop-closures branch March 31, 2023 21:33
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants