-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update delete account button spacing #17125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-gt-update-delete-account-button-spacing.0 because the annotations in the pull request description changed |
2422e38
to
28b531f
Compare
started the job as gitpod-build-gt-update-delete-account-button-spacing.2 because the annotations in the pull request description changed |
/hold |
/unhold |
/hold |
Tide queue seems empty. Opportunistically removing hold. 🌮 🌮 /unhold |
Thanks @svenefftinge for taking a look. 🌮 🌮 |
Description
Minor spacing change to the delete account button under
/account
. Seems like a small side effect from the typography components added in #16673.This will add a ~spacing-scale-3 (
1rem
/16px
) between the heading and the button.Posting for visibility below a screenshot from Foundations / Spacing in the component library in our Figma team, to justify the change.
gitpod/components/dashboard/src/user-settings/Account.tsx
Lines 93 to 97 in 2d4f946
Cc @easyCZ because relevant discussion (internal)
Cc @selfcontained because #16673
How to test
Go to user account settings and notice the button spacing in the delete account section.
Release Notes
Documentation
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh