Skip to content

Update delete account button spacing #17125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Apr 3, 2023

Description

Minor spacing change to the delete account button under /account. Seems like a small side effect from the typography components added in #16673.

This will add a ~spacing-scale-3 (1rem/16px) between the heading and the button.

BEFORE AFTER
button-before button-after

Posting for visibility below a screenshot from Foundations / Spacing in the component library in our Figma team, to justify the change.

Spacing Guidelines
Spacing

<Heading2 className="mt-12">Delete Account</Heading2>
<Subheading>This action will remove all the data associated with your account in Gitpod.</Subheading>
<Button type="danger.secondary" onClick={() => setModal(true)}>
Delete Account
</Button>

Cc @easyCZ because relevant discussion (internal)

Cc @selfcontained because #16673

How to test

Go to user account settings and notice the button spacing in the delete account section.

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-update-delete-account-button-spacing.0 because the annotations in the pull request description changed
(with .werft/ from main)

@gtsiolis gtsiolis force-pushed the gt/update-delete-account-button-spacing branch from 2422e38 to 28b531f Compare April 3, 2023 17:28
@gtsiolis gtsiolis marked this pull request as ready for review April 3, 2023 17:29
@gtsiolis gtsiolis requested a review from a team April 3, 2023 17:29
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 3, 2023
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-update-delete-account-button-spacing.2 because the annotations in the pull request description changed
(with .werft/ from main)

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Apr 6, 2023

/hold

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Apr 6, 2023

/unhold

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Apr 6, 2023

/hold

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Apr 7, 2023

Tide queue seems empty. Opportunistically removing hold. 🌮 🌮

/unhold

@roboquat roboquat merged commit 401cd01 into main Apr 7, 2023
@roboquat roboquat deleted the gt/update-delete-account-button-spacing branch April 7, 2023 14:48
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Apr 7, 2023

Thanks @svenefftinge for taking a look. 🌮 🌮

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
Status: In Validation
Development

Successfully merging this pull request may close these issues.

3 participants