Skip to content

[server] don't wait for queued prebuilds #17129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Conversation

svenefftinge
Copy link
Contributor

Description

This change skips queued prebuilds, so that users will get a fresh workspace instead of waiting for a prebuild that has not even started yet.

Also fixes a null pointer error (https://linear.app/gitpod/issue/WEB-82/cannot-read-properties-of-undefined-reading-id), that occurs when we try to obtain an instanceid for a queued prebuild in order to let users wait for them to finish.

Related Issue(s)

Fixes https://linear.app/gitpod/issue/WEB-82/cannot-read-properties-of-undefined-reading-id

How to test

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@svenefftinge svenefftinge requested a review from a team April 4, 2023 07:35
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-se-no-wait-queued-pb.1 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat added the size/S label Apr 4, 2023
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 4, 2023
@roboquat roboquat merged commit 2401a18 into main Apr 4, 2023
@roboquat roboquat deleted the se/no-wait-queued-pb branch April 4, 2023 07:44
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
Status: In Validation
Development

Successfully merging this pull request may close these issues.

3 participants