Skip to content

Add new feature for custom workspace network CIDR #17145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 6, 2023

Description

The default workspace network cell uses a private range that can conflict with some pre-existing network in the VPC that creates a network routing error (no route to host) when we try to reach any IP address of the such subnet.
For this scenario, we introduce a new ws-daemon parameter that allows us to set a different subnet. If the parameter is not present, we use the default value we use.

fixes WKS-50

How to test

  • Use the default configuration
    • Verify workspaces run
    • Check the IP addresses in the workspace. The value should be 10.0.5.2/30
  • Change the installer configuration to set a different subnet
    • Verify workspaces run
    • Check the IP addresses in the workspace. The value should match the subnet, and the workspace should have the second IP address in the range.

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-workspace-cidr.3 because the annotations in the pull request description changed
(with .werft/ from main)

@aledbf aledbf force-pushed the aledbf/workspace-cidr branch 2 times, most recently from 7cd79ea to eed0983 Compare April 6, 2023 16:29
@aledbf aledbf force-pushed the aledbf/workspace-cidr branch from 15e333b to 592cd46 Compare April 6, 2023 18:24
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-workspace-cidr.15 because the annotations in the pull request description changed
(with .werft/ from main)

@aledbf aledbf marked this pull request as ready for review April 6, 2023 18:36
@aledbf aledbf requested a review from a team April 6, 2023 18:36
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Apr 6, 2023
@Furisto
Copy link
Member

Furisto commented Apr 6, 2023

LGTM but holding in case you want to take care of the comments.

@aledbf
Copy link
Member Author

aledbf commented Apr 7, 2023

Running additional tests before merging

@aledbf
Copy link
Member Author

aledbf commented Apr 7, 2023

/gh run recreate-vm

@aledbf
Copy link
Member Author

aledbf commented Apr 7, 2023

/werft run with-clean-slate-deployment=true with-preview=true recreate-vm=true

👍 started the job as gitpod-build-aledbf-workspace-cidr.17
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-workspace-cidr.18 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-workspace-cidr.19 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-workspace-cidr.20 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-workspace-cidr.21 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat merged commit 9cf0243 into main Apr 7, 2023
@roboquat roboquat deleted the aledbf/workspace-cidr branch April 7, 2023 11:17
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/L team: workspace Issue belongs to the Workspace team
Projects
No open projects
Status: Awaiting Deployment
Development

Successfully merging this pull request may close these issues.

3 participants