-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add new feature for custom workspace network CIDR #17145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
899b16e
to
bcfa2ac
Compare
started the job as gitpod-build-aledbf-workspace-cidr.3 because the annotations in the pull request description changed |
7cd79ea
to
eed0983
Compare
15e333b
to
592cd46
Compare
started the job as gitpod-build-aledbf-workspace-cidr.15 because the annotations in the pull request description changed |
LGTM but holding in case you want to take care of the comments. |
Running additional tests before merging |
/gh run recreate-vm |
/werft run with-clean-slate-deployment=true with-preview=true recreate-vm=true 👍 started the job as gitpod-build-aledbf-workspace-cidr.17 |
started the job as gitpod-build-aledbf-workspace-cidr.18 because the annotations in the pull request description changed |
started the job as gitpod-build-aledbf-workspace-cidr.19 because the annotations in the pull request description changed |
started the job as gitpod-build-aledbf-workspace-cidr.20 because the annotations in the pull request description changed |
started the job as gitpod-build-aledbf-workspace-cidr.21 because the annotations in the pull request description changed |
Description
The default workspace network cell uses a private range that can conflict with some pre-existing network in the VPC that creates a network routing error (
no route to host
) when we try to reach any IP address of the such subnet.For this scenario, we introduce a new ws-daemon parameter that allows us to set a different subnet. If the parameter is not present, we use the default value we use.
fixes WKS-50
How to test
10.0.5.2/30
Release Notes
Documentation
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh