Skip to content

Update new workspace button style #17165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Apr 11, 2023

Description

Minor button style change on the new new workspace flow.

BEFORE AFTER
Screenshot 2023-04-11 at 18 16 29 Screenshot 2023-04-11 at 18 16 37

How to test

Go to /new and notice the new block button style of the primary action button.

Release Notes

Update new workspace button style

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@gtsiolis gtsiolis marked this pull request as ready for review April 12, 2023 15:12
@gtsiolis gtsiolis requested a review from a team April 12, 2023 15:12
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 12, 2023
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-update-new-workspace-button-style.1 because the annotations in the pull request description changed
(with .werft/ from main)

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Apr 13, 2023

Thanks for taking a look, @easyCZ. 🌮 🌮

Removing hold.

/unhold

@roboquat roboquat merged commit 82bbd7c into main Apr 13, 2023
@roboquat roboquat deleted the gt/update-new-workspace-button-style branch April 13, 2023 08:27
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
Status: In Validation
Development

Successfully merging this pull request may close these issues.

3 participants