Migrate checkbox component #17171
Merged
Migrate checkbox component #17171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [dashboard] migrate to CheckBoxInput (#16768) * [dashboard] remove CheckBox comp usage * [dashboard] remove `CheckBox` on team settings * [dashboard] remove border on checkbox click state * [dashboard] refactor code for `CheckboxInput`
|
started the job as gitpod-build-bmh-devansu-migrate-checkbox-component.3 because the annotations in the pull request description changed |
14 tasks
easyCZ
approved these changes
Apr 12, 2023
|
Looking at this now! 👀 Referenced also the original issue (#16768) in the PR description above. |
gtsiolis
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
UX LGTM. 🌮 🌮
Thanks for opening this PR @selfcontained to pickup changes from #16813 and unblock from merging this.
Removing hold.
LET'S DO THIS! 🏀
/unhold
This was referenced Apr 12, 2023
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a PR to facilitate @Devansu-Yadav's contributions in #16813
I made a couple changes on top of the ones in the linked PR.
CheckboxInputContainerwrapper at times, I reworked theCheckboxInputFieldinto a more explicitCheckboxListField, andCheckboxInputintoCheckboxInputField. This means that in most cases, you can use<CheckboxInputField/>and have the proper form styles/spacing without needing to add any wrapper components.valueprops passed in a few spots.Related Issue(s)
Fixes WEB-115, #16768
How to test
Preview Env: https://bmh-devans98e355c547.preview.gitpod-dev.com/workspaces
These changes were tested previously in #16813 - but can also be tested in the preview environment by visiting different locations updated in the PR and using checkbox inputs to make sure they work.
Release Notes
Documentation
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh/hold