Skip to content

Remove unused PodSecurityPolicy feature #17176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Remove unused PodSecurityPolicy feature #17176

merged 1 commit into from
Apr 13, 2023

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 12, 2023

Description

The PSP feature is behind a setting that we are not using.

The goal is to be able to upgrade to k8s 1.25/1.26 (updating the k8s dependencies, the PSP is not present anymore)

Release Notes

NONE

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-remove-psp.1 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-remove-psp.2 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-remove-psp.3 because the annotations in the pull request description changed
(with .werft/ from main)

@aledbf
Copy link
Member Author

aledbf commented Apr 13, 2023

/gh run recreate-vm

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-remove-psp.4 because the annotations in the pull request description changed
(with .werft/ from main)

@aledbf aledbf marked this pull request as ready for review April 13, 2023 14:06
@aledbf aledbf requested a review from a team April 13, 2023 14:06
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Apr 13, 2023
Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/gh run recreate-vm

😋 wishful thinking 😉

The goal is to be able to upgrade to k8s 1.25/1.26 (updating the k8s dependencies, the PSP is not present anymore)

🥂

@roboquat roboquat merged commit 541f6f6 into main Apr 13, 2023
@roboquat roboquat deleted the aledbf/remove-psp branch April 13, 2023 20:13
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XXL team: workspace Issue belongs to the Workspace team
Projects
No open projects
Status: Awaiting Deployment
Development

Successfully merging this pull request may close these issues.

3 participants