Skip to content

Remove the obsolete CheckBox component #17188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2023
Merged

Remove the obsolete CheckBox component #17188

merged 1 commit into from
Apr 23, 2023

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Apr 12, 2023 •
edited
Loading

Description

Pick up changes from the community contribution in #17186. Cc @Devansu-Yadav

For more context, see relevant section in How we develop.

Related Issue(s)

Fixes #17103

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@gtsiolis gtsiolis requested a review from a team April 12, 2023 15:11
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 12, 2023
gtsiolis
gtsiolis commented Apr 12, 2023
View reviewed changes
Copy link
Contributor Author

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🌮 🌮

Leaving this on the review requests queue for the @gitpod-io/engineering-webapp team.

@gtsiolis
Copy link
Contributor Author

Removing hold as code changes have been approved.

Thanks @easyCZ for taking a look and @Devansu-Yadav for contributing! 🏀

/unhold

@roboquat roboquat merged commit 90b7d65 into main Apr 23, 2023
@roboquat roboquat deleted the gt/merge-17186 branch April 23, 2023 10:50
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
🍎 WebApp Team
Status: In Validation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the obsolete checkbox component
4 participants
@gtsiolis @easyCZ @roboquat @Devansu-Yadav