Skip to content

[dashboard] handle needs_verification on create #17203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

svenefftinge
Copy link
Contributor

@svenefftinge svenefftinge commented Apr 13, 2023

Description

Handles the NEEDS_VERIFICATION error code when creating a fresh workspace by showing the phone number verification dialog.

Related Issue(s)

Fixes #17076
Fixes WEB-126

How to test

Try starting a workspace, you should see the verification dialog
(I've patched the server component in this preview env to always throw the error, twilio is not setup so no way to verify)

https://svenefftinb82038aac6.preview.gitpod-dev.com/new/

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-svenefftinge-startworkspacewithoptions-17076.1 because the annotations in the pull request description changed
(with .werft/ from main)

@svenefftinge svenefftinge marked this pull request as ready for review April 13, 2023 12:17
@svenefftinge svenefftinge requested a review from a team April 13, 2023 12:17
@svenefftinge svenefftinge requested a review from gtsiolis as a code owner April 13, 2023 12:17
@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team labels Apr 13, 2023
@svenefftinge
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit dcebffd into main Apr 13, 2023
@roboquat roboquat deleted the svenefftinge/startworkspacewithoptions-17076 branch April 13, 2023 12:40
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
Status: In Validation
Development

Successfully merging this pull request may close these issues.

StartWorkspaceWithOptions: account validation not shown (error code 411)
3 participants