Skip to content

experimental IDEs feature flag #17240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2023
Merged

experimental IDEs feature flag #17240

merged 2 commits into from
Apr 19, 2023

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Apr 17, 2023

Description

Introduces a new feature flag which enables IDEs to be optionally marked as experimental. When an IDE is experimental, it will only show to users whose ConfigCat response for experimentalIdes returns true.

Preview status

Gitpod was successfully deployed to your preview environment.

Related Issue(s)

Needed to introduce #17196.

How to test

  • In the preview environment, the VS Code Browser option should not be available, unless you add yourself to the corresponding ConfigCat flag -- experimentalIdes in our non-prod ConfigCat.

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • analytics=segment
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-ide-experimental-flag.1 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team team: IDE labels Apr 17, 2023
@filiptronicek
Copy link
Member Author

filiptronicek commented Apr 17, 2023

Please do not unhold until we revert 1e073fb 🙏

@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 19, 2023

Removing hold as both @gitpod-io/engineering-webapp and @gitpod-io/engineering-ide teams approved the code changes.

/unhold

Friendly reminder that @gtsiolis is an additional reviewer for changes in the components/dashboard folder, but not required to additionally approve if someone from @gitpod-io/engineering-webapp already approved the changes, see CODEOWNERS. 💡

@roboquat roboquat merged commit f85d4e4 into main Apr 19, 2023
@roboquat roboquat deleted the ide/experimental-flag branch April 19, 2023 12:52
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed: IDE IDE change is running in production deployed Change is completely running in production labels Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: IDE team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants