Skip to content

[server] Metrics for sessions with JWTs WEB-102 #17302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 22, 2023

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Apr 20, 2023

Description

  • Expose metrics on number of sessions which contained JWT cookie

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • analytics=segment
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@easyCZ easyCZ requested a review from a team April 20, 2023 12:52
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 20, 2023
@easyCZ easyCZ changed the title [server] Metrics for sessions with JWTs [server] Metrics for sessions with JWTs WEB-102 Apr 20, 2023
@geropl
Copy link
Member

geropl commented Apr 21, 2023

Seeing this in logs:

{"@type":"type.googleapis.com/google.devtools.clouderrorreporting.v1beta1.ReportedErrorEvent","serviceContext":{"service":"server","version":"mp-server-count-sessions-with-jwts-gha.7702"},"component":"server","severity":"ERROR","time":"2023-04-21T09:37:15.596Z","message":"(node:30) UnhandledPromiseRejectionWarning: TypeError: Cannot read properties of undefined (reading '_mp_server_bd3882035f_preview_gitpod_dev_com_jwt_')\n    at SessionHandlerProvider.<anonymous> (/app/node_modules/@gitpod/server/dist/src/session-handler.js:58:40)\n    at Generator.next (<anonymous>)\n    at fulfilled (/app/node_modules/@gitpod/server/dist/src/session-handler.js:19:58)\n    at processTicksAndRejections (node:internal/process/task_queues:96:5)\n(Use `node --trace-warnings ...` to show where the warning was created)","loggedViaConsole":true}

@roboquat roboquat added size/S and removed size/M labels Apr 21, 2023
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, server runs, build's green ✔️

@easyCZ
Copy link
Member Author

easyCZ commented Apr 22, 2023

/unhold

@roboquat roboquat merged commit ec8c66e into main Apr 22, 2023
@roboquat roboquat deleted the mp/server-count-sessions-with-jwts branch April 22, 2023 19:22
easyCZ added a commit that referenced this pull request Apr 22, 2023
roboquat pushed a commit that referenced this pull request Apr 23, 2023
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants