Skip to content

[wsman-mk2] Use mk2 tls certificates for server and bridge #17317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Apr 21, 2023

Description

When we do a full installation of Gitpod (i.e. webapp and workspace components all within the same cluster) and ws-manager-mk2 is specified use the ws-manager-mk2 secret instead of the mk1 secret (mk1 will not exist).

Related Issue(s)

Fixes WKS-105

How to test

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • analytics=segment
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@Furisto Furisto added team: workspace Issue belongs to the Workspace team feature: ws-manager-mk2 labels Apr 21, 2023
@Furisto Furisto self-assigned this Apr 21, 2023
@Furisto Furisto marked this pull request as ready for review April 21, 2023 10:21
@Furisto Furisto requested a review from a team April 21, 2023 10:21
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 21, 2023
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@roboquat roboquat merged commit 09bb1b2 into main Apr 24, 2023
@roboquat roboquat deleted the fo/mk2-server branch April 24, 2023 11:19
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production feature: ws-manager-mk2 size/S team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants