[server] Only try to delete Stripe subscription if the user's BillingMode is "usage-based" #17318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Mode is "usage-based"
easyCZ
reviewed
Apr 24, 2023
easyCZ
reviewed
Apr 24, 2023
| } | ||
| } | ||
|
|
||
| protected async cancelSubscription(subscriptionId: string): Promise<void> { |
There was a problem hiding this comment.
Ah, this is a remnant of our split brain dealing with Stripe.
On usage, there's CancelSubscription which would ideally handle every detail of this, such that it can be uniformly called.
There was a problem hiding this comment.
Yep, totally agree that we should fold this code into the usage side.
So far I've refrained because I'm waiting for authN. But we could also do it earlier, too! Maybe out of scope for this PR, though.
easyCZ
approved these changes
Apr 24, 2023
|
/unhold |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Fixes WEB-191
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh/hold