Skip to content

[server/dash] Remove license RPCs/view WEB-214 #17342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 24, 2023
Merged

[server/dash] Remove license RPCs/view WEB-214 #17342

merged 4 commits into from
Apr 24, 2023

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Apr 24, 2023 •
edited by geropl
Loading

Description

No longer used.

Related Issue(s)

Fixes WEB-214

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • analytics=segment
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@easyCZ easyCZ requested a review from a team April 24, 2023 11:51
@easyCZ easyCZ requested a review from gtsiolis as a code owner April 24, 2023 11:51
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 24, 2023
@easyCZ easyCZ requested a review from a team April 24, 2023 11:57
geropl
geropl approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@easyCZ
Copy link
Member Author

easyCZ commented Apr 24, 2023

/unhold

@easyCZ
Copy link
Member Author

easyCZ commented Apr 24, 2023

/hold requires SID

mads-hartmann
mads-hartmann approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installer changes look harmless to me

@easyCZ
Copy link
Member Author

easyCZ commented Apr 24, 2023

Thanks mads

/unhold

@easyCZ
Copy link
Member Author

easyCZ commented Apr 24, 2023

/hold managed to get a merge conflict in the meantime..

@easyCZ easyCZ force-pushed the mp/server-remove-license branch from 030412d to 283ecef Compare April 24, 2023 13:24
@easyCZ
Copy link
Member Author

easyCZ commented Apr 24, 2023

/unhold

@roboquat roboquat merged commit eb2cead into main Apr 24, 2023
@roboquat roboquat deleted the mp/server-remove-license branch April 24, 2023 14:29
@roboquat roboquat added the deployed: webapp Meta team change is running in production label May 15, 2023
@gtsiolis gtsiolis mentioned this pull request Jul 11, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mads-hartmann mads-hartmann mads-hartmann approved these changes

@geropl geropl geropl approved these changes

@gtsiolis gtsiolis Awaiting requested review from gtsiolis

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production size/L team: security-infrastructure-and-delivery team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@easyCZ @mads-hartmann @geropl @roboquat