[preview] force gce when providing infrastructure, avoid harvester #17475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
kylos101
changed the title
vulkoingim
approved these changes
May 3, 2023
...and actually use spot by changing the default for gce_use_spot We'll address the disk pressure issues (which cause pods to evict on install, but eventually succeed) in a separate PR.
|
@vulkoingim could I ask for a follow-up review? I enabled spot VMs, and bumped the sizes up. |
vulkoingim
approved these changes
May 3, 2023
|
Works (provisions spot VMs) for integration tests, too: https://github.com/gitpod-io/gitpod/actions/runs/4874305742/jobs/8695071978 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Harvester is technical debt we no longer wish to support or maintain. [1] Force gce for all preview environments.
Existing harvester preview environments will need to be either:
leeway run dev/preview:delete-preview, and then recreated (make a local branch to test separate from this one)kubecontext -d <context-name>, and then recreatedAssuming this is received well, a follow-on PR will remove related tech debt, which helps jobs select between harvester and gce.
After this lands in main share ☝️ in #development-pipeline so teammates know to make related adjustments.
Related Issue(s)
Related to PDEO-2
How to test
leeway run dev:previewproduces a preview backed by GCEDocumentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh/hold