Skip to content

[wsman-mk2] Schedule on non experimental nodes #17481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2023
Merged

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented May 3, 2023

Description

Only schedule on on experimental nodes if experimental mode is disabled

Related Issue(s)

Fixes WKS-123

Preview status

gitpod:summary

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • analytics=segment
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@Furisto Furisto added team: workspace Issue belongs to the Workspace team feature: ws-manager-mk2 labels May 3, 2023
@Furisto Furisto requested a review from a team May 3, 2023 11:27
@Furisto Furisto self-assigned this May 3, 2023
Copy link
Member

@WVerlaek WVerlaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove the label in preview envs as well:

kubectl --kubeconfig "${PREVIEW_K3S_KUBE_PATH}" --context "${PREVIEW_K3S_KUBE_CONTEXT}" --namespace="${PREVIEW_NAMESPACE}" label nodes "${PREVIEW_K3S_KUBE_CONTEXT}" gitpod.io/experimental="true" --overwrite

@roboquat roboquat added size/S and removed size/XS labels May 3, 2023
@roboquat roboquat merged commit f77c236 into main May 3, 2023
@roboquat roboquat deleted the fo/experimental-nodes branch May 3, 2023 11:43
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production feature: ws-manager-mk2 size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants