[dashboard] update document title on setup #17603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
approved these changes
May 15, 2023
|
|
||
| type Props = { | ||
| onComplete: () => void; | ||
| }; | ||
| const DedicatedSetup: FC<Props> = ({ onComplete }) => { | ||
| useDocumentTitle("Welcome - Gitpod"); |
There was a problem hiding this comment.
Would we want to swap the ordering? The more tabs I have open, the fewer characters I will see and as such showing Gitpod instead of Welcome may be preferrable.
There was a problem hiding this comment.
If we're setting the title here, do we need to also reset it elsewhere such that after you complete the setup, we no longer show this?
There was a problem hiding this comment.
It is set elsewhere using the pattern " - Gitpod"
Comment on lines
+9
to
+15
| export function useDocumentTitle(title?: string) { | ||
| useEffect(() => { | ||
| if (title && title.length > 0) { | ||
| document.title = title; | ||
| } | ||
| }, [title]); | ||
| } |
There was a problem hiding this comment.
There are many occurences of something like
useEffect(() => {
document.title = "New Organization — Gitpod";
}, []);
Could you update these to use the effect?
svenefftinge
force-pushed
the
se/update-title
branch
from
6c7b060 to
368821e
Compare
|
/unhold |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Fixes WEB-344
How to test
Documentation
Preview status
gitpod:summary
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh/hold