[test] Fix RPC retries & improve logging #18210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: workspace
kylos101
reviewed
Jul 10, 2023
| @@ -206,32 +206,30 @@ type RpcClient struct { | |||
|
|
|||
| func (r *RpcClient) Call(serviceMethod string, args any, reply any) error { | |||
| var err error | |||
| var new *RpcClient | |||
| cl := r | |||
There was a problem hiding this comment.
There are a couple spots (below) where we can return w/o closing the RpcClient. Should we add a defer cl.Close()?
There was a problem hiding this comment.
we only close it to then later re-open it through a new call to Instrument, in general this Call method shouldn't close the client as it can be used for more rpc calls afterwards
aledbf
approved these changes
Jul 10, 2023
|
/unhold |
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instrumentfirst after closing the connection on failure, and to return when the call succeeds (was always calling the rpc 5 times before)Related Issue(s)
Relates to WKS-153
How to test
https://github.com/gitpod-io/gitpod/actions/runs/5506674959
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh/hold