Skip to content

allow disconnect for org owned users #18221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

selfcontained
Copy link
Contributor

@selfcontained selfcontained commented Jul 10, 2023

Description

Allow org owned users to disconnect all git providers.

Related Issue(s)

Fixes WEB-619

How to test

To test this you can join my org on the preview env. w/ your google login by following this link:

https://brad-web-6a8b1c5163c.preview.gitpod-dev.com/login/brad

  • Go to User Settings / Git Providers and connect to a provider.
  • Verify you can disconnect from that provider even though it's the only connection you have.

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@selfcontained selfcontained marked this pull request as ready for review July 11, 2023 16:49
@selfcontained selfcontained requested a review from a team July 11, 2023 16:49
@selfcontained selfcontained requested a review from gtsiolis as a code owner July 11, 2023 16:49
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 11, 2023
Copy link
Contributor

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check this on the server side. But we can do that later as the current check is also done client side.

@svenefftinge
Copy link
Contributor

I'm unholding because the fix is good and the testing issues seem unrelated.

/unhold

@roboquat roboquat merged commit 7540857 into main Jul 12, 2023
@roboquat roboquat deleted the brad/web-619-allow-sso-users-to-remove-all-their-git-provider-connections branch July 12, 2023 07:26
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants