Skip to content

Update VS Code Browser to 1.80.1 #18279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 14, 2023
Merged

Update VS Code Browser to 1.80.1 #18279

merged 3 commits into from
Jul 14, 2023

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Jul 13, 2023 •
edited by mustard-mh
Loading

Description

Update code to 1.80.1

Progress

How to test

  • Switch to VS Code Browser Insiders in settings.
  • Start a workspace.
  • Test the following:
    • terminals are preserved and resized properly between window reloads
    • WebViews are working
    • extension host process: check language smartness and debugging
    • extension management (installing/uninstalling)
    • install the VIM extension to test web extensions
    • that user data is synced across workspaces as well as on workspace restarts, especially for extensions
      • extensions from .gitpod.yml are not installed as sync
      • extensions installed as sync are actually synced to all new workspaces
    • settings should not contain any mentions of MS telemetry
    • WebSockets and workers are properly proxied
      • diff editor should be operable
      • trigger reconnection with window.WebSocket.disconnectWorkspace(), check that old WebSockets are closed and new opened of the same amount
    • workspace specific commands should work, i.e. F1 → type Gitpod
    • that a PR view is preloaded when opening a PR URL
    • test gp open and gp preview
    • test open in VS Code Desktop, check gp open and gp preview in task/user terminals
    • telemetry data like vscode_extension_gallery is collected in Segment

Preview status

Gitpod was successfully deployed to your preview environment.

Werft options:

  • /werft with-preview
  • /werft analytics=segment

@filiptronicek filiptronicek self-assigned this Jul 13, 2023
@filiptronicek filiptronicek marked this pull request as ready for review July 13, 2023 20:38
@filiptronicek filiptronicek requested a review from a team July 13, 2023 20:38
@filiptronicek
Copy link
Member Author

@mustard-mh I am trying to view events in Segment, but Staging Trusted does not show anything new. Do you know whether I'm looking in the correct place?

@jeanp413
Copy link
Member

/hold

@mustard-mh
Copy link
Contributor

@filiptronicek There may be something wrong in our GHA, segment key in server is empty

image

But from Network tab, client does send events

image

@roboquat roboquat merged commit 648dc30 into main Jul 14, 2023
@roboquat roboquat deleted the ide/code-release branch July 14, 2023 08:42
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jul 14, 2023
@filiptronicek filiptronicek mentioned this pull request Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanp413 jeanp413 jeanp413 approved these changes

Assignees

@filiptronicek filiptronicek

Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: code (browser) size/XS team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@filiptronicek @jeanp413 @mustard-mh @roboquat