Change gh runners concurrency rules #18281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
reviewed
Jul 14, 2023
| # github.ref_name is set if the event is NOT a pull_request - it contains only the branch name. | ||
| group: ${{ github.head_ref || github.ref_name }}-configuration | ||
| group: ${{ github.ref == 'refs/heads/main' && github.run_id || github.sha }}-configuration | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
Why is it ok to cancel here? E.g., are we skipping the build step, then, later? How does it work? 🤔
There was a problem hiding this comment.
This only applies if you force-push the same commit.
There was a problem hiding this comment.
I don't think it would cancel on force push, because the SHA is different then.
|
/unhold |
AlexTugarev
added a commit
that referenced
this pull request
Jul 21, 2023
This reverts commit 0bb6aaa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh/hold