Skip to content

[server] fix flaky tests #18363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2023
Merged

[server] fix flaky tests #18363

merged 1 commit into from
Jul 26, 2023

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Jul 26, 2023

Description

Fixes a race condition where we would need to await initialization of the Authorizer before using it.

Summary generated by Copilot

🤖 Generated by Copilot at 3f747a3

Refactored the Authorizer class to use a proxy pattern and removed unused code from tests and SpiceDBAuthorizer. This improves the code structure and reduces complexity.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh
  • with-monitoring

/hold

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look sensible if tests pass

@svenefftinge
Copy link
Member Author

/unhold

@roboquat roboquat merged commit 9b4a6db into main Jul 26, 2023
@roboquat roboquat deleted the se/fix-test branch July 26, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants