[server] Remove obsolete (Theia) User Storage Resource #18377
Conversation
|
@akosyakov, does it make sense to remove this Theia legacy? |
|
Taking a tour now... 👀 |
| ) { | ||
| resourceRev = fromTheiaRev; | ||
| } | ||
| const resourceRev = (await this.db.getResource(req.user.id, resourceKey, ref, collection))?.rev; | ||
| if (!resourceRev) { |
There was a problem hiding this comment.
!resourceRev || resourceRev === fromTheiaRev ?
some clients can already cache it?
There was a problem hiding this comment.
although it should fail like that anyway after trying to access content storage
There was a problem hiding this comment.
Would be awesome, if you'd double-check this area. I don't want to break users.
There was a problem hiding this comment.
@jeanp413 could you double check please, on first glance it looks alright
It is more important whether are users still migrating. It seems like 1% still does [1]. But we discussed it in the past and were inclined to remove [2], so should be alright. |
There was a problem hiding this comment.
There are also the following two files that need to be updated:
/workspace/gitpod/components/gitpod-protocol/go/gitpod-service.go
/workspace/gitpod/components/gitpod-protocol/go/mock.go
not sure if they are manually edited or generated) Looks like generated but it never works for me so I would usally edit them manually 🤷
|
/gh run recreate-vm Comment triggered a workflow runStarted workflow run: 5701264548
|
|
/unhold |
Description
Summary generated by Copilot
🤖 Generated by Copilot at a67a742
This pull request removes all the code and dependencies related to the user storage resources feature from the Gitpod server, protocol, and database components. User storage resources were a deprecated feature that allowed users to allocate disk space for their workspaces. This cleanup simplifies the code base and reduces the complexity of the Gitpod services.
Related Issue(s)
Fixes #
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh/hold