Call e2e test workflow from main build with installer version #18381
+30
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WVerlaek
changed the title
Furisto
approved these changes
Jul 28, 2023
WVerlaek
commented
Jul 28, 2023
| } >> $GITHUB_OUTPUT | ||
| else | ||
| { | ||
| echo "name=workspace-integration-test-${{ github.run_id }}-${{ github.run_attempt }}" | ||
| } >> $GITHUB_OUTPUT | ||
| fi | ||
|
|
||
| if [[ '${{ github.event.inputs.version }}' != '' ]]; then | ||
| if [[ '${{ inputs.version }}' != '' ]]; then |
There was a problem hiding this comment.
for workflow_call github.event.inputs.* doesnt exist and need to use inputs.* instead. Works now: https://github.com/gitpod-io/gitpod/actions/runs/5692256844/job/15429016661?pr=18381#step:6:12
inputs.* is also available for workflow_dispatch
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix: in the previous PR I had configured the e2e tests to run on push events to main, but it was not using the installer version of that pushed commit (it chooses the last successful green build).
Now, instead of triggering on pushes to main, have the
Buildworkflow trigger the e2e test workflow on main, and explicitly pass the installer version of that commit.Summary generated by Copilot
🤖 Generated by Copilot at 8c56e91
This pull request adds the ability to run workspace integration tests on the main branch using a reusable workflow. It modifies the
.github/workflows/workspace-integration-tests.ymland.github/workflows/build.ymlfiles to enable this functionality.Related Issue(s)
Fixes #
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold