Skip to content

[server] enhanced mocha setups #18390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2023
Merged

[server] enhanced mocha setups #18390

merged 1 commit into from
Aug 2, 2023

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Jul 31, 2023

Description

Changes the mocah setup in server component:

  • run generated JS instead using very slow ts-node. (a bit more inconvenient as we have to rebuild/watch)
  • working mocha extension in VS Code
  • remove the launch configs (because the test explorer works better)
Screenshot 2023-07-31 at 13 21 09
Summary generated by Copilot

🤖 Generated by Copilot at 56159f4

This pull request improves the testing setup for the server component, by aligning the database configuration with the test environment, using the compiled JavaScript files instead of the TypeScript files, and adding the hbenl.vscode-test-explorer extension to run and debug tests from VS Code in Gitpod.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with me if it works, I remember we went similar way with Theia at some point because of differences running with ts-node or without

Not sure where we should document though testing flow that one HAS to recompile before running tests.

@svenefftinge svenefftinge force-pushed the se/better-mocha branch 4 times, most recently from c9c8ef4 to 6074500 Compare August 2, 2023 07:10
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@svenefftinge
Copy link
Member Author

/unhold

@roboquat roboquat merged commit 3d790a8 into main Aug 2, 2023
@roboquat roboquat deleted the se/better-mocha branch August 2, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants