Skip to content

[server] remove Project.userId #18391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2023
Merged

[server] remove Project.userId #18391

merged 1 commit into from
Jul 31, 2023

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Jul 31, 2023

Description

Since we no longer support user-owned projects, we should remove any leftover code paths and the property on the type.

Summary generated by Copilot

🤖 Generated by Copilot at 3579171

No summary available (Limit exceeded: required to process 147298 tokens, but only 50000 are allowed per call)

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

We no longer support user-owned projects.
This removes related leftovers.
@svenefftinge svenefftinge force-pushed the se/remove-userproject branch from 3579171 to 9129f6a Compare July 31, 2023 11:41
@geropl
Copy link
Member

geropl commented Jul 31, 2023

Taking a look here 👀

@AlexTugarev
Copy link
Member

@svenefftinge, there is a high number of projects still connected to personal account. Are those already or getting orphaned by this PR?

@geropl
Copy link
Member

geropl commented Jul 31, 2023

there is a high number of projects still connected to personal account. Are those already or getting orphaned by this PR?

My understanding that those are already migrated with the "org-only" migration. 👍

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested and works ✔️

@svenefftinge
Copy link
Member Author

@svenefftinge, there is a high number of projects still connected to personal account. Are those already or getting orphaned by this PR?

They are all either markedDeleted or have a teamId.

@svenefftinge
Copy link
Member Author

/unhold

@roboquat roboquat merged commit d2b220f into main Jul 31, 2023
@roboquat roboquat deleted the se/remove-userproject branch July 31, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants