[JB GW]: Support ssh over websocket tunnel #18415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
force-pushed
the
ak/jb_gw_web_socket_tunnel
branch
from
936f0a9 to
31136a8
Compare
akosyakov
force-pushed
the
ak/jb_gw_web_socket_tunnel
branch
3 times, most recently
from
3e1f1b7 to
90ab5a4
Compare
akosyakov
force-pushed
the
ak/jb_gw_web_socket_tunnel
branch
from
90ab5a4 to
4f592db
Compare
|
Follow the test steps, everything looks good. But I can't see |
Do you check GW logs? |
collect host and client log -> 
|
|
it looks good then, no? |
mustard-mh
approved these changes
Aug 4, 2023
|
/unhold |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some networks SSH either blocked or accessible via complicated setup (bastions, proxy jumps). This PR introduces an alternative mode of connectivity via HTTP tunnel directly into Gitpod workspace, i.e. work around SSH Gateway. This mode is either picked is a fallback or a user can force it in settings.
✅ depends on #18411
Summary generated by Copilot
🤖 Generated by Copilot at 936f0a9
This pull request adds support for different SSH connection methods to the JetBrains IDE plugin, and includes the generated Java code for the supervisor API. It modifies the
GitpodConnectionProvider.ktfile to implement the new features, and adds theGitpodWebSocketTunnelServer.ktfile to enable web socket tunneling. It also removes theapifolder from the.gitignorefile and adds theInfoServiceGrpc.javafile to the repository.Related Issue(s)
Fixes EXP-279
How to test
Force SSH over HTTP tunnelsetting, leave it disabled for now.gp previewstill working. You can check that in GW idea.log you don't have yet logs with prefixes likegitpod: tunnelgitpod: tunnel. When a client is clsoed, you should see a log that the tunnel is stopped.Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold