Skip to content

Se/featureflag-spicedb #18428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Se/featureflag-spicedb #18428

merged 1 commit into from
Aug 3, 2023

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Aug 3, 2023

Description

Checks the centralizedPermissions feature-flag before accessing spicedb.

Only this commit

Summary generated by Copilot

🤖 Generated by Copilot at 3c2b8dc

This pull request implements the centralized permissions feature flag for the server component, which uses the Spicedb service to manage user, project, and organization relationships. It also updates the authorizer, relationship-updater, organization-service, and projects-service classes to use the new feature flag logic and the Spicedb queries and operations. Additionally, it adds and modifies some test cases for these classes, introduces a new metric for relationship updates, and fixes some minor typos and errors.

Related Issue(s)

Fixes EXP-366

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM ✔️

Would be great to test this, maybe after it got merged, in a preview env.

@svenefftinge svenefftinge force-pushed the se/featureflag-spicedb branch from 3c2b8dc to ed3677a Compare August 3, 2023 15:51
@roboquat roboquat added size/M and removed size/XXL labels Aug 3, 2023
@svenefftinge
Copy link
Member Author

I have just tested it.

  • disabled the featureFlag and restarted server pod
  • delete spicedb
  • login, create orgs, create projects worked flawlessly

@svenefftinge
Copy link
Member Author

/unhold

@roboquat roboquat merged commit 22c2a55 into main Aug 3, 2023
@roboquat roboquat deleted the se/featureflag-spicedb branch August 3, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants