Add a new trust bundle for custom SSL certificates #18450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandajavarma
reviewed
Aug 7, 2023
|
/gh run recreate-vm=true Comment triggered a workflow runStarted workflow run: 5786692878
|
|
/gh run recreate-vm=true Comment triggered a workflow runStarted workflow run: 5793817101
|
nandajavarma
approved these changes
Aug 8, 2023
|
/gh run recreate-vm=true Comment triggered a workflow runStarted workflow run: 5795863545
|
nandajavarma
force-pushed
the
aledbf/custom-cert-trust
branch
from
0ed33bf to
e18f54c
Compare
|
/gh run recreate-vm=true Comment triggered a workflow runStarted workflow run: 5796648395
|
|
/gh run recreate-vm=true Comment triggered a workflow runStarted workflow run: 5796910545
|
nandajavarma
force-pushed
the
aledbf/custom-cert-trust
branch
2 times, most recently
from
59bc477 to
36ceca7
Compare
|
/gh run recreate-vm=true Comment triggered a workflow runStarted workflow run: 5797393527
|
nandajavarma
force-pushed
the
aledbf/custom-cert-trust
branch
from
36ceca7 to
3ad0967
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Copilot
🤖 Generated by Copilot at 3b41472
Add support for custom SSL certificates in cert-manager. Use a new variable and a config map to provide custom CA certificates to cert-manager pods.
Related Issue(s)
Fixes #
How to test
gitpod-customer-certificate-bundleexists/etc/ssl/certs/ca-certificates.crtin a workspace is mounted volume from theca-certificatesconfigmap/etc/ssl/certs/ca-certificates.crtcontains the certificatePreview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold