Skip to content

Adding project scopes for desktop oauth client #18452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

selfcontained
Copy link
Contributor

@selfcontained selfcontained commented Aug 7, 2023

Description

This adds the scopes needed to the desktop oauth client configuration to allow listing team projects.

image
Summary generated by Copilot

🤖 Generated by Copilot at 7712c17

Add a new scope for the desktop app to access team projects. Update db.ts to grant the scope to the desktopClient object.

Related Issue(s)

Fixes EXP-390

How to test

  • Login to the Desktop App via dedicated using the preview environment url.
  • Verify that the ListProjects call didn't fail in your network tab

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving

@selfcontained selfcontained marked this pull request as ready for review August 8, 2023 13:58
@selfcontained selfcontained requested a review from a team as a code owner August 8, 2023 13:58
@selfcontained
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit ba39001 into main Aug 8, 2023
@roboquat roboquat deleted the bmh/desktop-oauth-client-projects-perms branch August 8, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants