Skip to content

[mysql] increase and monitor poolsize #18457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2023
Merged

[mysql] increase and monitor poolsize #18457

merged 1 commit into from
Aug 8, 2023

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Aug 8, 2023

Description

Increases the connection limit for MySQL to 40 (from 20) per instance. Also adds pool observation in server components.

Summary generated by Copilot

🤖 Generated by Copilot at d903fd3

Increased MySQL connection pool size in components/gitpod-db/src/typeorm/typeorm.ts. This improves database performance and scalability for Gitpod.

Related Issue(s)

Fixes EXP-392

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@svenefftinge svenefftinge changed the title [mysql] increase poolside [mysql] increase poolsize Aug 8, 2023
@roboquat roboquat removed the size/XS label Aug 8, 2023
@svenefftinge svenefftinge marked this pull request as ready for review August 8, 2023 11:21
@svenefftinge svenefftinge requested a review from a team as a code owner August 8, 2023 11:21
@svenefftinge svenefftinge changed the title [mysql] increase poolsize [mysql] increase and monitor poolsize Aug 8, 2023
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as advertized

Screenshot 2023-08-08 at 15 14 38

we could add also gitpod_typeorm_max_connections equal value of connection limit, that we can use it in alerts, but we can hardcode it as well there

@svenefftinge
Copy link
Member Author

/unhold

@roboquat roboquat merged commit 7e2b0ef into main Aug 8, 2023
@roboquat roboquat deleted the something branch August 8, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants