remove definetly-gp support #18492
Merged
remove definetly-gp support #18492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
commented
Aug 11, 2023
mustard-mh
previously requested changes
Aug 11, 2023
|
I also move it to draftm because it would be better to deploy after the weekend. |
compare to previous attempts it does not remove anything related to ExternalImageConfigFile
akosyakov
force-pushed
the
ak/remove_definetly_gp
branch
from
05b077d to
c4b7517
Compare
|
/gh run recreate-vm=true Comment triggered a workflow runStarted workflow run: 5852329980
|
AlexTugarev
reviewed
Aug 14, 2023
| @@ -37,7 +37,7 @@ export class ImageSourceProvider { | |||
|
|
|||
| const imgcfg = config.image; | |||
| if (ExternalImageConfigFile.is(imgcfg)) { | |||
| // we're asked to pull the Dockerfile from a repo possibly different than the one we're opening a workspace for (e.g. definitely-gp). | |||
| // we're asked to pull the Dockerfile from a repo possibly different than the one we're opening a workspace for. | |||
There was a problem hiding this comment.
This has to stay, if I remember correctly.
'Just paying attention to what could break.
There was a problem hiding this comment.
yes, it was a reason why it broke last time, we create ExternalImageConfigFile above, did not process it here
AlexTugarev
approved these changes
Aug 14, 2023
|
Yeah, it seems one image build leads to out of disk. We will need to recrreat VM or clean up somehow. Fine to merge? I've tested. |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
compare to previous attempts it does not remove anything related to ExternalImageConfigFile
Summary generated by Copilot
🤖 Generated by Copilot at 05b077d
This pull request removes the code and configuration related to the definitely-gp and inferred config features, which are no longer supported by Gitpod. It affects the
config-provider.ts,config.go,gitpod-service.go,protocol.ts,image-source-provider.ts,example-config.yaml,configmap.go,types.go, andconfig.mdfiles.Related Issue(s)
Fixes #
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold