[new-workspace] Fix recent repositories for BBS – EXP-411 #18497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexTugarev
commented
Aug 11, 2023
|
|
||
| export function getFullRepositoryUrl(ws: Workspace): string | undefined { | ||
| if (CommitContext.is(ws.context)) { | ||
| return `https://${ws.context.repository.host}/${getFullRepositoryName(ws)}`; |
There was a problem hiding this comment.
This is just bogus. For BBS there is no symmetry between owner+repo and the repository URL. Instead one need to know if it's a personal or a project repository.
AlexTugarev
commented
Aug 11, 2023
components/server/src/bitbucket-server/bitbucket-server-repository-provider.ts
Outdated
Show resolved
Hide resolved
components/server/src/bitbucket-server/bitbucket-server-repository-provider.ts
Show resolved
Hide resolved
AlexTugarev
commented
Aug 14, 2023
components/server/src/bitbucket-server/bitbucket-server-repository-provider.spec.ts
Outdated
Show resolved
Hide resolved
svenefftinge
approved these changes
Aug 14, 2023
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Copilot
🤖 Generated by Copilot at 34a8cc7
This pull request removes unused functions from the
WorkspaceTypetype, adds a new test and fixes a bug for the Bitbucket Server integration, and uses the original clone URL for the workspace context.Related Issue(s)
Fixes EXP-411
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold