Skip to content

[fga] Introduce GitpodTokenService #18502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2023
Merged

[fga] Introduce GitpodTokenService #18502

merged 1 commit into from
Aug 16, 2023

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Aug 12, 2023

Description

Summary generated by Copilot

🤖 Generated by Copilot at 64a3604

This pull request introduces a new server component, GitpodTokenService, to manage Gitpod tokens for API access. It also adds the corresponding permissions, read_tokens and write_tokens, to the Spicedb schema and the UserPermission type. The Gitpod server API methods related to Gitpod tokens are refactored to use the new service. Unit tests for the service are added as well.

Related Issue(s)

Fixes https://linear.app/gitpod/issue/EXP-420

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As said in the comments, we need to keep the guardAccess calls in all server-impl methods.

@roboquat roboquat added size/XL and removed size/L labels Aug 15, 2023
@svenefftinge
Copy link
Member

Thanks! This looks good now. Could you squash your commits and merge?

@jeanp413
Copy link
Member Author

/unhold

@roboquat roboquat merged commit 6cf3aa2 into main Aug 16, 2023
@roboquat roboquat deleted the jp/southern-eel branch August 16, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants