[fga] Introduce EnvVarService #18503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanp413
commented
Aug 12, 2023
akosyakov
reviewed
Aug 14, 2023
geropl
reviewed
Aug 14, 2023
geropl
reviewed
Aug 14, 2023
geropl
reviewed
Aug 14, 2023
geropl
reviewed
Aug 14, 2023
akosyakov
reviewed
Aug 15, 2023
akosyakov
reviewed
Aug 15, 2023
akosyakov
reviewed
Aug 15, 2023
akosyakov
reviewed
Aug 15, 2023
akosyakov
reviewed
Aug 15, 2023
| } | ||
|
|
||
| @injectable() | ||
| export class EnvVarService { |
There was a problem hiding this comment.
Should it go under user folder? User should not depend on projects. Maybe it is better than have envvar folder.
jeanp413
force-pushed
the
jp/unnecessary-thrush
branch
from
adcb96a to
7a426dc
Compare
jeanp413
commented
Aug 16, 2023
jeanp413
force-pushed
the
jp/unnecessary-thrush
branch
from
86fe43e to
093a452
Compare
|
@svenefftinge Updated, can you take another look 🙏 |
svenefftinge
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
LGTM - also tested in preview env
please squash the commits
jeanp413
force-pushed
the
jp/unnecessary-thrush
branch
from
093a452 to
2740099
Compare
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Copilot
🤖 Generated by Copilot at 0e48ca9
Refactored the server component to separate the logic of user-level and workspace-level environment variables. Introduced a new
EnvVarServiceclass for user-level environment variables, and renamed the existingEnvVarServiceclass toEnvVarResolverfor workspace-level environment variables. Updated the imports, references, and tests accordingly.Related Issue(s)
Fixes https://linear.app/gitpod/issue/EXP-409/
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold