[ws-manager-mk2] remove experimental mode feature #18513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylos101
changed the title
aledbf
approved these changes
Aug 14, 2023
kylos101
force-pushed
the
kylos101/ENG-666
branch
3 times, most recently
from
e21f567 to
d11055e
Compare
kylos101
force-pushed
the
kylos101/ENG-666
branch
from
97ebcc4 to
99edeac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove experimentalMode for ws-manager-mk2.
Also updates the VM image with changes from https://github.com/gitpod-io/gitpod-packer-gcp-image/pull/246.
Summary generated by Copilot
🤖 Generated by Copilot at 0570d2e
This pull request removes the feature flag and related code for the experimental workspace manager mk2, which is now the default and only workspace manager in Gitpod. It simplifies the configuration and pod creation logic for the workspace components.
Related Issue(s)
Fixes ENG-21
Related to ENG-639
How to test
curl lama.sh | shand assert you can browse to the port it exposescurl --connect-timeout 10 -s -H "Metadata-Flavor: Google" 'http://169.254.169.254/computeMetadata/v1/instance/'times out, and the exit status is 28.Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold