[fga] more FGA checks and service use #18517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
commented
Aug 15, 2023
| @@ -1057,9 +1058,6 @@ export class GitpodServerImpl implements GitpodServerWithTracing, Disposable { | |||
| const ws = await this.workspaceService.getWorkspace(user.id, workspaceId); | |||
| await this.guardAccess({ kind: "workspace", subject: ws }, "delete"); | |||
|
|
|||
| // for good measure, try and stop running instances | |||
| await this.internalStopWorkspace(ctx, user.id, ws, "deleted via API"); | |||
There was a problem hiding this comment.
@geropl I deleted this here because it happens as part of deleteWorkspace below.
There was a problem hiding this comment.
Only difference I see is the "delete via API" is replaced by "deleted via WorkspaceService". But not sure how we used that anyway. 👍
|
Taking a closer look now 👀 |
geropl
approved these changes
Aug 15, 2023
14 tasks
|
@svenefftinge Would be awesome if you could merge this soon so I can rebase 🚀 🤓 🙏 |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Copilot
🤖 Generated by Copilot at 3ac3eb7
This pull request implements the user deletion feature and refactors some of the server components to improve authorization and code quality. It adds a new
deletepermission to theUserPermissiontype and theUserschema inSpiceDB, and uses theAuthorizerand theWorkspaceServicefor permission checks and workspace operations. It also adds new tests for theWorkspaceServicemethods and refactors some of the existing code to use dependency injection and remove redundancy.Related Issue(s)
Fixes #
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold