Update GitLab REST client library #18523

AlexTugarev · 2023-08-16T09:00:23Z

Description

Execute gitlab tests manually

Summary generated by Copilot

`🤖 Generated by Copilot at a8ec98a`

Updated @gitbeaker/node dependency to fix GitLab pagination bug and moved package.json file to components/server directory to simplify workspace setup and dependency management.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

🏷️ Name - at-bump-gi5363ad8af0
🔗 URL - at-bump-gi5363ad8af0.preview.gitpod-dev.com/workspaces.
📚 Documentation - See our internal documentation for information on how to interact with your preview environment.
📦 Version - at-bump-gitlab-client-gha.16010

Build Options

Build

/werft with-werft
Run the build with werft instead of GHA
leeway-no-cache
/werft no-test
Run Leeway with --dont-test

Publish

/werft publish-to-npm
/werft publish-to-jb-marketplace

Installer

analytics=segment
with-dedicated-emulation
workspace-feature-flags
Add desired feature flags to the end of the line above, space separated

Preview Environment / Integration Tests

/werft with-local-preview
If enabled this will build install/preview
/werft with-preview
/werft with-large-vm
/werft with-gce-vm
If enabled this will create the environment on GCE infra
with-integration-tests=all
Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
with-monitoring

/hold

geropl · 2023-08-16T09:02:10Z

@AlexTugarev I checked last time, and all versions of gitbeaker/node still pull the outdated packages.
IMO we need to switch to gitbeaker/rest (or however it was called).

socket-security · 2023-08-16T09:04:32Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
@gitbeaker/rest	39.12.0	network	`+0`	94.6 kB	jdalrymple

🚮 Removed packages: @gitbeaker/[email protected]

AlexTugarev · 2023-08-16T13:20:50Z

@gitbeaker/rest is requiring to update to node 18.

jeanp413 · 2023-08-24T17:39:17Z

/gh run recreate-vm

Comment triggered a workflow run

Started workflow run: 5967083536

recreate_vm: true

jeanp413 · 2023-08-24T19:21:56Z

/gh run recreate-vm

Comment triggered a workflow run

Started workflow run: 5968021546

recreate_vm: true

jeanp413 · 2023-08-24T20:01:41Z

What does it mean to Execute gitlab tests manually? connect with gitlab from dashboard and open some repo?

akosyakov · 2023-08-25T08:02:23Z

/gh run recreate-vm

Comment triggered a workflow run

Started workflow run: 5973428167

recreate_vm: true

mustard-mh

Code LGTM, tried with project / workspace create, prebuild webhook worked well too

mustard-mh · 2023-08-25T11:39:33Z

What does it mean to Execute gitlab tests manually? connect with gitlab from dashboard and open some repo?

@jeanp413 Maybe is that in those *.spec.ts files related to Gitlab, most of them will skip if we don't provide a test token, so you can export this var if you want to Execute gitlab tests manually

skip(ifEnvVarNotSet("GITPOD_TEST_TOKEN_GITLAB")

mustard-mh · 2023-08-25T11:47:31Z

Once want to try with it, but test cases repo are owned by Alex, so I can't do test manually. Would be good to have test cases under gitpod accounts?

components/server/src/gitlab/api.ts

AlexTugarev · 2023-08-28T07:34:18Z

npx mocha --opts mocha.opts './**/gitlab-*.spec.js'

I'm looking into failing tests right now.

  22 passing (14s)
  2 pending
  7 failing

  1) TestGitlabContextParser
       testTreeContext_03:
     Uncaught Error: Not Found

AlexTugarev · 2023-08-28T12:00:36Z

Just realized that branches are not retrievable.

When trying to parse the following context, it fails fetching branch wip
https://gitlab.com/AlexTugarev/gp-test/-/blob/wip/README.md

Update: this might be cause by a change of the error shape of the library. It is not expected to throw on 404, but return a Not Found error object. It looks like the weak detected broke, thus all kind of similar cases could be broken. See attached screenshot.

Several places relied on a particular shape of errors.

AlexTugarev · 2023-08-28T12:52:51Z

components/server/src/gitlab/api.ts

@@ -128,16 +115,16 @@ export namespace GitLab {
            return !!something && something.name === "GitLabApiError";
        }
        export function isNotFound(error: ApiError): boolean {
-            return !!error.httpError?.description.startsWith("404");


I've seen the startsWith of undefined before, and it was related to GitLab contexts. 🙏🏻 hopefully that's the cause

AlexTugarev · 2023-08-28T14:09:00Z

/unhold

AlexTugarev requested a review from a team as a code owner August 16, 2023 09:00

roboquat added do-not-merge/hold size/M labels Aug 16, 2023

github-actions bot added the team: team-experience label Aug 16, 2023

AlexTugarev marked this pull request as draft August 16, 2023 13:20

roboquat added the do-not-merge/work-in-progress label Aug 16, 2023

roboquat added size/XL and removed size/M labels Aug 24, 2023

AlexTugarev and others added 3 commits August 24, 2023 15:31

[server] update gitlab REST client library

8b3bc11

clean up workspace packages

c451467

Update gitlab rest client

b64cead

jeanp413 force-pushed the at/bump-gitlab-client branch from b2a13f4 to b64cead Compare August 24, 2023 15:42

roboquat added size/L and removed size/XL labels Aug 24, 2023

Fix yarn.lock

4f3f2f4

Update chainguard node image

89886c9

jeanp413 marked this pull request as ready for review August 24, 2023 19:55

roboquat removed the do-not-merge/work-in-progress label Aug 24, 2023

akosyakov requested a review from mustard-mh August 25, 2023 09:36

mustard-mh approved these changes Aug 25, 2023

View reviewed changes

AlexTugarev commented Aug 28, 2023

View reviewed changes

components/server/src/gitlab/api.ts Outdated Show resolved Hide resolved

AlexTugarev marked this pull request as draft August 28, 2023 11:58

roboquat added the do-not-merge/work-in-progress label Aug 28, 2023

Catch up with GitLab client library changes.

040a4b9

Several places relied on a particular shape of errors.

AlexTugarev marked this pull request as ready for review August 28, 2023 12:49

roboquat added size/XL and removed do-not-merge/work-in-progress size/L labels Aug 28, 2023

AlexTugarev requested a review from mustard-mh August 28, 2023 12:49

AlexTugarev commented Aug 28, 2023

View reviewed changes

[gitlab] fix project typings

c346dde

roboquat removed the do-not-merge/hold label Aug 28, 2023

roboquat merged commit 5efb011 into main Aug 28, 2023

roboquat deleted the at/bump-gitlab-client branch August 28, 2023 14:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update GitLab REST client library #18523

Update GitLab REST client library #18523

Uh oh!

AlexTugarev commented Aug 16, 2023 •

edited by jeanp413

Loading

Uh oh!

geropl commented Aug 16, 2023

Uh oh!

socket-security bot commented Aug 16, 2023 •

edited

Loading

Uh oh!

AlexTugarev commented Aug 16, 2023

Uh oh!

jeanp413 commented Aug 24, 2023 •

edited by github-actions bot

Loading

Uh oh!

jeanp413 commented Aug 24, 2023 •

edited by github-actions bot

Loading

Uh oh!

jeanp413 commented Aug 24, 2023

Uh oh!

akosyakov commented Aug 25, 2023 •

edited by github-actions bot

Loading

Uh oh!

mustard-mh left a comment

Uh oh!

mustard-mh commented Aug 25, 2023

Uh oh!

mustard-mh commented Aug 25, 2023 •

edited

Loading

Uh oh!

Uh oh!

AlexTugarev commented Aug 28, 2023

Uh oh!

AlexTugarev commented Aug 28, 2023 •

edited

Loading

Uh oh!

AlexTugarev Aug 28, 2023

Uh oh!

AlexTugarev commented Aug 28, 2023

Uh oh!

Uh oh!

Update GitLab REST client library #18523

Update GitLab REST client library #18523

Uh oh!

Conversation

AlexTugarev commented Aug 16, 2023 • edited by jeanp413 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

🤖 Generated by Copilot at a8ec98a

Related Issue(s)

How to test

Documentation

Preview status

Build Options

Uh oh!

geropl commented Aug 16, 2023

Uh oh!

socket-security bot commented Aug 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlexTugarev commented Aug 16, 2023

Uh oh!

jeanp413 commented Aug 24, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment triggered a workflow run

Uh oh!

jeanp413 commented Aug 24, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment triggered a workflow run

Uh oh!

jeanp413 commented Aug 24, 2023

Uh oh!

akosyakov commented Aug 25, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment triggered a workflow run

Uh oh!

mustard-mh left a comment

Choose a reason for hiding this comment

Uh oh!

mustard-mh commented Aug 25, 2023

Uh oh!

mustard-mh commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

AlexTugarev commented Aug 28, 2023

Uh oh!

AlexTugarev commented Aug 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlexTugarev Aug 28, 2023

Choose a reason for hiding this comment

Uh oh!

AlexTugarev commented Aug 28, 2023

Uh oh!

Uh oh!

AlexTugarev commented Aug 16, 2023 •

edited by jeanp413

Loading

`🤖 Generated by Copilot at a8ec98a`

socket-security bot commented Aug 16, 2023 •

edited

Loading

jeanp413 commented Aug 24, 2023 •

edited by github-actions bot

Loading

jeanp413 commented Aug 24, 2023 •

edited by github-actions bot

Loading

akosyakov commented Aug 25, 2023 •

edited by github-actions bot

Loading

mustard-mh commented Aug 25, 2023 •

edited

Loading

AlexTugarev commented Aug 28, 2023 •

edited

Loading