Skip to content

[fga] WorkspaceService port ops #18527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2023
Merged

[fga] WorkspaceService port ops #18527

merged 1 commit into from
Aug 17, 2023

Conversation

geropl
Copy link
Member

@geropl geropl commented Aug 16, 2023

Description

Moves openPort, closePort and getOpenPorts to WorkspaceService, guarded by the access permission.

Why access? The old perm system called used operatio "update", but the actual check was identical to "get".

Summary generated by Copilot

🤖 Generated by Copilot at 0e4c6aa

Refactor port-related methods in GitpodServerImpl to use WorkspaceService and add tests for port operations.

Related Issue(s)

Relates to: EXP-207

How to test

  • sign up with user 1 and 2 (in a different session/browser)
    • unblock user 2
  • enable centralizedPermissions for user 2 and user 1
  • user 1: start a workspace with a service serving a private port
    • note that the ports view works ✔️
  • user 2: try to access the port
    • note that you see a blank page ✔️
  • user 1: make that port public ✔️
  • user 2: reload, and see the page being loaded ✔️

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@geropl geropl marked this pull request as ready for review August 17, 2023 07:21
@geropl geropl requested a review from a team as a code owner August 17, 2023 07:21
Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@geropl
Copy link
Member Author

geropl commented Aug 17, 2023

/unhold

Thanks for the quick review! 🙏

@roboquat roboquat merged commit 553f9b2 into main Aug 17, 2023
@roboquat roboquat deleted the gpl/fga-ports branch August 17, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants