[server] createProject should not query all repositories – EXP-459 #18532
Conversation
except for github.com when using the GitHub App.
AlexTugarev
force-pushed
the
at/createProject-fix
branch
from
ed2075f to
c3e4f87
Compare
AlexTugarev
force-pushed
the
at/createProject-fix
branch
from
c3e4f87 to
a15a073
Compare
Quickly re-tested that projects can created an webhooks are installed like before. |
| type === "GitLab" || | ||
| type === "Bitbucket" || | ||
| type === "BitbucketServer" || | ||
| (type === "GitHub" && (authProvider?.host !== "github.com" || !this.config.githubApp?.enabled)) |
There was a problem hiding this comment.
Feels like we are checking for all types we support explicitly. I wonder for which cases this code is not applicable...? 🤔
There was a problem hiding this comment.
|
(reviewing now 👀 ) |
| } else { | ||
| return await this.scmService.canInstallWebhook(currentUser, cloneURL); | ||
|
|
||
| // note: the GitHub App based check is not included in the ProjectService due |
There was a problem hiding this comment.
To me this is kind of a red flag to not but both things togehter in a SCMService, honestly. Also, most of that functionality seems util functions around HostContext and the likes, maybe we can place them in such a place (without injection) which resolves/avoids the cycle.
I would be ok to merge this today in favor of turnarounds, if we resolve it tomorrow maybe? 🙃
There was a problem hiding this comment.
Let's resolve this in a different context 🙏🏻
|
/unhold |
This is to fix issues when listing all repositories is super expensive and might even burn all the rate limit at the Git provider.
Description
Summary generated by Copilot
🤖 Generated by Copilot at 8c04321
This pull request adds a new method to check the user's ability to create a Gitpod project from a GitHub repository using the GitHub App integration. It also refactors the
createProjectAPI method to use the new check.Related Issue(s)
Fixes EXP-459
How to test
See that you can create projects as it's used to be.
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold