-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add support for pod disruption budget #18547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ac3e004
to
44557ab
Compare
/gh run recreate-vm=true Comment triggered a workflow runStarted workflow run: 5943714160
|
/gh run recreate-vm=true Comment triggered a workflow runStarted workflow run: 5943956377
|
/gh run recreate-vm=true Comment triggered a workflow runStarted workflow run: 5944493282
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The one downside is that right now this is only configurable in code and should we need to remove/adjust it, we'll need a new version of gitpod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved to unblock
but short description why such configuration is specified would be helpful to understand implications
Description
Enable pod disruption budget to avoid the migration of multiple replicas at the same time when we need to drain nodes.
fixes ENG-725
Summary generated by Copilot
🤖 Generated by Copilot at 44ab5ea
Add pod disruption budget for ws-manager-mk2 component. This improves the availability and resilience of the workspace management service by limiting the impact of voluntary pod disruptions.
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold