Skip to content

Add support for pod disruption budget #18547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Add support for pod disruption budget #18547

merged 1 commit into from
Aug 25, 2023

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 18, 2023

Description

Enable pod disruption budget to avoid the migration of multiple replicas at the same time when we need to drain nodes.

fixes ENG-725

Summary generated by Copilot

🤖 Generated by Copilot at 44ab5ea

Add pod disruption budget for ws-manager-mk2 component. This improves the availability and resilience of the workspace management service by limiting the impact of voluntary pod disruptions.

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@aledbf
Copy link
Member Author

aledbf commented Aug 22, 2023

/gh run recreate-vm=true

Comment triggered a workflow run

Started workflow run: 5943714160

  • recreate_vm: true

@aledbf
Copy link
Member Author

aledbf commented Aug 22, 2023

/gh run recreate-vm=true

Comment triggered a workflow run

Started workflow run: 5943956377

  • recreate_vm: true

@aledbf
Copy link
Member Author

aledbf commented Aug 22, 2023

/gh run recreate-vm=true

Comment triggered a workflow run

Started workflow run: 5944493282

  • recreate_vm: true

@aledbf
Copy link
Member Author

aledbf commented Aug 23, 2023

root@preview-aledbf-pdb:/home/ubuntu# k get pdb
NAME                    MIN AVAILABLE   MAX UNAVAILABLE   ALLOWED DISRUPTIONS   AGE
blobserve-pdb           N/A             1                 1                     2m13s
dashboard-pdb           N/A             1                 1                     2m
node-labeler-pdb        N/A             1                 1                     2m19s
openvsx-proxy-pdb       N/A             1                 1                     117s
proxy-pdb               N/A             1                 1                     105s
public-api-server-pdb   N/A             1                 1                     115s
server-pdb              N/A             1                 1                     2m4s
ws-manager-mk2-pdb      N/A             1                 1                     102s
ws-proxy-pdb            N/A             1                 1                     2m26s

Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The one downside is that right now this is only configurable in code and should we need to remove/adjust it, we'll need a new version of gitpod

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved to unblock

but short description why such configuration is specified would be helpful to understand implications

@roboquat roboquat merged commit f27b16e into main Aug 25, 2023
@roboquat roboquat deleted the aledbf/pdb branch August 25, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants