[fga] WorkspaceService.controlAdmission #18549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| level: "owner" | "everyone", | ||
| check: (workspace: Workspace, instance?: WorkspaceInstance) => Promise<void> = async () => {}, | ||
| ): Promise<void> { | ||
| await this.auth.checkPermissionOnWorkspace(userId, "access", workspaceId); |
There was a problem hiding this comment.
We should probably have a specific permission for changing the sharing properties in another PR. At least if we decide to keep this feature.
There was a problem hiding this comment.
Jep. Was on the brink to introduce one, then kept the current behavior. 👍
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduced WorkspaceService.controlAdmission, incl. workspace sharing implemented with FGA
Summary generated by Copilot
🤖 Generated by Copilot at 73ce811
This pull request adds a new feature to allow sharing workspaces with any user in an organization. It modifies the authorization logic and database schema for workspaces, and adds new methods and tests to the
WorkspaceServiceandAuthorizerclasses. It also updates the Spicedb schema and permissions to support the newsharedrelation.Related Issue(s)
Relates to: EXP-207
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold