🐛 Fix: Broken logic in Org. member loading state #18555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how do you end up on an org without members? |
svenefftinge
approved these changes
Aug 21, 2023
yeah in Named/"Siddhant Khare"'s Org, we always have a single person who is a Owner, but the Owner doesn't show up in the Members filter (which is kinda technically correct though , but this filter confusing for single person organization) Screen.Recording.2023-08-21.at.1.16.34.PM.mov |
|
/unhold |
|
Thanks! didn't realize the filter bit |
roboquat
deleted the
siddhant/exp-419-fix-organization-members-loading-state
branch
TIL. Thank you for catching this, @Siddhant-K-code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue of a misleading infinite spinner on the "Members" list within single-person Organizations. The fix aims to provide an accurate loading state representation for a better user experience.
Summary generated by Copilot
🤖 Generated by Copilot at 5df6761
Improved the user interface of the
Memberscomponent in the dashboard. Added feedback for loading and empty states.Related Issue(s)
Fixes EXP-419 : Fix organization members loading state
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold