[fga] prebuild access #18560
Merged
[fga] prebuild access #18560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
reviewed
Aug 21, 2023
geropl
reviewed
Aug 21, 2023
| await this.auth.checkPermissionOnWorkspace(userId, "access", workspaceId); | ||
|
|
||
| // check access | ||
| await this.getWorkspace(userId, workspaceId); |
There was a problem hiding this comment.
Nit: it still works, but I wonder what the motivation for this change is? Feels a bit like hiding the check somewhat. 🤔
There was a problem hiding this comment.
Ah, missed the indirection.
Can we maybe work around this pattern? E.g., by moving the "is prebuild" check in doGetWorkspace into Authorizer, and call it here as well? 🤔
There was a problem hiding this comment.
Resolved sync: As it's only two call-sites, we go with this approach for now.
svenefftinge
force-pushed
the
se/fga-prebuilds
branch
from
0b49b53 to
e597707
Compare
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Distinguishes access checks for workspaces between prebuilds and regular workspaces.
Summary generated by Copilot
🤖 Generated by Copilot at 0b49b53
This pull request enhances the security of prebuilds by enforcing
Project-based access control for both reading prebuilds and accessing prebuild workspaces. It also simplifies some code inworkspace-service.tsby reusing existing permission checks.Related Issue(s)
Fixes EXP-490
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold