[fga] WorkspaceService.getWorkspace(s)

[geropl]

Description

Moves getWorkspace and getWorkspace to WorkspaceService

Note:

• svc.getWorkspace returns WorkspaceInfo instead of Workspace now
  • this has performance implications, as this is our most-called API methods
  • it might make sense to merge the two queries here
• svc.getWorkspaces is limited to the owner's workspaces only just like before (ref)
• we could easily change this if we:
  • align on an alternative qualifier to make the query performant enough (e.g. organizationId)
  • add that identifier to the API
  • add the missing indexes on the DB
• I opted to not do that now due to focus on FGA

Summary generated by Copilot

🤖 Generated by Copilot at 30a23dc

Refactor GitpodServerImpl and WorkspaceService classes to improve performance and readability. Use new getWorkspace method that returns WorkspaceInfo objects and censors instances. Update tests and other methods accordingly.

Related Issue(s)

Related to EXP-207

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

• 🏷️ Name - gpl-fga-get-ws
• 🔗 URL - gpl-fga-get-ws.preview.gitpod-dev.com/workspaces.
• 📚 Documentation - See our internal documentation for information on how to interact with your preview environment.
• 📦 Version - gpl-fga-get-ws-gha.15763

Build Options

Build

• /werft with-werft
  Run the build with werft instead of GHA
• leeway-no-cache
• /werft no-test
  Run Leeway with --dont-test

Publish

• /werft publish-to-npm
• /werft publish-to-jb-marketplace

Installer

• analytics=segment
• with-dedicated-emulation
• workspace-feature-flags
  Add desired feature flags to the end of the line above, space separated

Preview Environment / Integration Tests

• /werft with-local-preview
  If enabled this will build install/preview
• /werft with-preview
• /werft with-large-vm
• /werft with-gce-vm
  If enabled this will create the environment on GCE infra
• with-integration-tests=all
  Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
• with-monitoring

/hold

[svenefftinge]

I'm ok with keeping all the duplicate find instance calls in gitpod-server-impl, but can we at least keep the non-needed check functions out of the WorkspaceService?

[geropl]

/unhold